Conversation
### Description Add hermetic tests validating Firestore index and security rule dispatch flows within `src/deploy/firestore/deploy.ts`. ### Scenarios Tested - Sequential initialization of defined configurations - Intermittent state retries ### Sample Commands `npm run mocha -- 'src/deploy/firestore/deploy.spec.ts'`
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
|
/gemini review |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a comprehensive unit test suite for the Firestore deployment logic in src/deploy/firestore/deploy.spec.ts. The tests cover various scenarios, including skipping deployment when no rules or indexes are present, handling successful rules and index deployments, and verifying retry logic for 404 errors during index deployment. Feedback focuses on adhering to the repository's TypeScript style guide by removing the use of as unknown as type assertions, which are used as escape hatches. Suggestions are provided to use proper type assertions, valid enum members, or Object.assign for more type-safe error object construction.
3 participants
Description
Add hermetic tests validating Firestore index and security rule dispatch flows within
src/deploy/firestore/deploy.ts.Scenarios Tested
Sample Commands
npm run mocha -- 'src/deploy/firestore/deploy.spec.ts'